Improve SeekBarMapper#2037
Merged
Merged
Conversation
0xnm
reviewed
May 16, 2024
| @Mock | ||
| lateinit var mockInternalLogger: InternalLogger | ||
|
|
||
| /* |
Member
There was a problem hiding this comment.
should it be left as commented out?
Contributor
Author
There was a problem hiding this comment.
Good call, this code should be deleted
Comment on lines
+146
to
+148
| // region Assertions | ||
| fun assertThatBoundsAreCloseEnough(actual: MobileSegment.Wireframe, expected: MobileSegment.Wireframe) { |
Member
There was a problem hiding this comment.
Suggested change
| // region Assertions | |
| fun assertThatBoundsAreCloseEnough(actual: MobileSegment.Wireframe, expected: MobileSegment.Wireframe) { | |
| // region Assertions | |
| fun assertThatBoundsAreCloseEnough(actual: MobileSegment.Wireframe, expected: MobileSegment.Wireframe) { |
| if (actualCornerRadius != null && expectedCornerRadius != null) { | ||
| assertThat(actualCornerRadius).isCloseTo(expectedCornerRadius, withinPercentage(5)) | ||
| } | ||
| } |
| @ForgeConfiguration(ForgeConfigurator::class) | ||
| internal class LegacySeekBarWireframeMapperTest : BaseSeekBarWireframeMapperTest() { | ||
|
|
||
| /* |
Contributor
Author
There was a problem hiding this comment.
Same, it's deleted
xgouchet
force-pushed
the
xgouchet/sr_ut_seekbar
branch
from
May 16, 2024 14:55
9a88e51 to
e086414
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2037 +/- ##
===========================================
+ Coverage 82.93% 83.17% +0.24%
===========================================
Files 491 491
Lines 17700 17697 -3
Branches 2683 2686 +3
===========================================
+ Hits 14678 14718 +40
+ Misses 2285 2238 -47
- Partials 737 741 +4
|
xgouchet
force-pushed
the
xgouchet/sr_ut_seekbar
branch
from
May 16, 2024 15:42
e086414 to
dadfe16
Compare
0xnm
approved these changes
May 16, 2024
xgouchet
force-pushed
the
xgouchet/sr_ut_seekbar
branch
from
May 17, 2024 07:09
dadfe16 to
5459252
Compare
ambushwork
reviewed
May 17, 2024
| const val OPAQUE_ALPHA_VALUE: Int = MAX_ALPHA_VALUE | ||
|
|
||
| /** The value corresponding to a 25% opaque Alpha. */ | ||
| const val PARTIALLY_OPAQUE_ALPHA_VALUE: Int = 0x44 |
Member
There was a problem hiding this comment.
a random mathematical comment here, 0x3f or 0x40 seems closer to 25% of opaque alpha.(Just wondering how 0x44 is calculated, although it has hardly any impact)
xgouchet
force-pushed
the
xgouchet/sr_ut_seekbar
branch
from
May 17, 2024 09:31
5459252 to
a23e0e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve SeekBarMapper and its unit tests: