RUM-4501 Enable desugaring for sample and single-fit apps#2036
Merged
mariusc83 merged 1 commit intoMay 21, 2024
Merged
Conversation
0xnm
reviewed
May 16, 2024
Comment on lines
+36
to
+38
| compileOptions { | ||
| isCoreLibraryDesugaringEnabled = true | ||
| } |
Member
There was a problem hiding this comment.
why do we need that? If I'm not wrong both Single FIT and Sample apps are running on API higher than 24? or you want to make them compatible if they are executed on emulator with Android below N?
Member
Author
There was a problem hiding this comment.
Exactly that, just to make sure.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/otel-support #2036 +/- ##
========================================================
- Coverage 63.61% 63.61% -0.00%
========================================================
Files 751 751
Lines 28352 28345 -7
Branches 4682 4681 -1
========================================================
- Hits 18034 18029 -5
+ Misses 9124 9121 -3
- Partials 1194 1195 +1 |
mariusc83
force-pushed
the
mconstantin/rum-4372/setup-ci-for-otel-module-release
branch
2 times, most recently
from
May 21, 2024 07:31
64fb3fc to
cd6e3f3
Compare
Base automatically changed from
mconstantin/rum-4372/setup-ci-for-otel-module-release
to
feature/otel-support
May 21, 2024 08:16
mariusc83
force-pushed
the
mconstantin/rum-4501/enable-desugaring-in-sample-app
branch
from
May 21, 2024 11:56
5f26f8a to
5712350
Compare
xgouchet
approved these changes
May 21, 2024
mariusc83
deleted the
mconstantin/rum-4501/enable-desugaring-in-sample-app
branch
May 21, 2024 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We are enabling desugaring for the sample and single-fit apps as they are the ones using the newly introduced
dd-sdk-android-trace-otelmodule.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)