RUM-4372 Setup the CI and gradle tests for the new dd-sdk-android-trace-otel module#2035
Conversation
mariusc83
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/otel-support #2035 +/- ##
========================================================
- Coverage 63.62% 63.62% -0.00%
========================================================
Files 751 751
Lines 28359 28358 -1
Branches 4682 4681 -1
========================================================
- Hits 18041 18040 -1
- Misses 9119 9121 +2
+ Partials 1199 1197 -2 |
| registerSubModuleAggregationTask("unitTestRelease", "testReleaseUnitTest", exceptions = setOf("dd-sdk-android-trace")) | ||
| registerSubModuleAggregationTask("unitTestDebug", "testDebugUnitTest", exceptions = setOf("dd-sdk-android-trace")) |
There was a problem hiding this comment.
there is no test task on the CI for Otel module?
There was a problem hiding this comment.
there is actually if you check that registerSubModuleAggregationTask it is doing this automatically for all the modules but let me double check in gitlab
There was a problem hiding this comment.
then another question :) what changed so that it allows us to run tests without these exceptions?
There was a problem hiding this comment.
:), yes good question there, I think I added this exception when I ported the Java code as an intermediary change and I forgot to remove it :(. I checked the data I changed those lines and it make sense.
1e98819 to
b49d5b0
Compare
| val tracingFeature = sdkCore.getFeature(Feature.TRACING_FEATURE_NAME) | ||
| ?.unwrap<Feature>() | ||
| val internalCoreWriterProvider = tracingFeature as? InternalCoreWriterProvider | ||
| if (tracingFeature == null || internalCoreWriterProvider == null) { |
There was a problem hiding this comment.
minor: checking whether tracingFeature is null may be redundant. tracingFeature can't be null without internalCoreWriterProvider also being
There was a problem hiding this comment.
not quite, you can have tracingFeature which is of type Feature but not implementing the InternalCoreWrirerProvider
4007772 to
64fb3fc
Compare
64fb3fc to
cd6e3f3
Compare
5 participants
What does this PR do?
Adding the gitlab step for publishing the
dd-sdk-android-trace-otelmoduleRemoving the
dd-sdk-android-traceunit tests exception, this was a leftover from a previous PR which I forgot to remove.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)