Improve the TextViewMapper unit tests#2034
Merged
Merged
Conversation
0xnm
approved these changes
May 15, 2024
| SwitchCompat::class.java, | ||
| SwitchCompatMapper( | ||
| textViewMapper, | ||
| textViewMapper as TextViewMapper<SwitchCompat>, |
Member
There was a problem hiding this comment.
this part with explicit casting looks dangerous and not very obvious (partially because it is not obvious that SwitchCompat, etc. are sub-classes of TextView). Is there a way to avoid explicit cast?
Contributor
Author
There was a problem hiding this comment.
Those cast are totally safe, but I agree they are not obvious.
They are temporary though, the next PRs will be about letting SwitchCompatMapper(and others) extend TextViewMapper instead.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2034 +/- ##
===========================================
- Coverage 83.14% 82.93% -0.22%
===========================================
Files 495 491 -4
Lines 17721 17700 -21
Branches 2689 2683 -6
===========================================
- Hits 14734 14678 -56
- Misses 2242 2285 +43
+ Partials 745 737 -8
|
jonathanmos
approved these changes
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Split the logic of the TextViewMapper in two classes: TextViewMapper and EditTextViewMapper, to simplify some of the logic and make testing easier.