Create package name consistency rule#2032
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2032 +/- ##
===========================================
+ Coverage 83.21% 83.27% +0.06%
===========================================
Files 486 495 +9
Lines 17716 17718 +2
Branches 2688 2688
===========================================
+ Hits 14742 14754 +12
+ Misses 2238 2226 -12
- Partials 736 738 +2
|
xgouchet
force-pushed
the
xgouchet/sr_packages
branch
from
May 15, 2024 06:06
0094d06 to
6595593
Compare
0xnm
reviewed
May 15, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
Thanks for the cleanup! I left some comments. My concern is about the usage of @InternalApi on the interfaces/non-final classes directly, because it is a limitation of the check, but if we are sure that implementation of the interface/class extension won't land in the legit public API, this is fine.
xgouchet
force-pushed
the
xgouchet/sr_packages
branch
from
May 15, 2024 10:03
6595593 to
f284941
Compare
0xnm
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR include a new Detekt rule enforcing our package naming policy:
(enum|data|sealed)? class,object,interface,fun,val|var) which is marked asinternalmust be in a package matching/**.internal.**/(enum|data|sealed)? class,object,interface,fun,val|var) which is not marked asinternalmust not be in a package matching/**.internal.**/