Improve UT for SR Obfuscators#2031
Merged
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/sr_ut_obfuscators
branch
from
May 13, 2024 10:58
803d45b to
4ad6c3c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2031 +/- ##
===========================================
+ Coverage 83.31% 83.39% +0.07%
===========================================
Files 485 485
Lines 17671 17671
Branches 2685 2685
===========================================
+ Hits 14722 14735 +13
+ Misses 2213 2200 -13
Partials 736 736
|
0xnm
approved these changes
May 13, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
nice one! happy to see Unicode supplementary planes coverage
|
|
||
| override fun obfuscate(stringValue: String): String { | ||
| return buildString { | ||
| return buildString(stringValue.length) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improve the UT regarding the obfuscators to be more exhaustive