RUM-4103 add telemetry to detect uncovered View/Drawable in Session Replay#2028
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2028 +/- ##
===========================================
- Coverage 83.32% 83.30% -0.02%
===========================================
Files 486 486
Lines 17662 17725 +63
Branches 2684 2689 +5
===========================================
+ Hits 14716 14765 +49
- Misses 2212 2221 +9
- Partials 734 739 +5
🚀 New features to boost your workflow:
|
jonathanmos
approved these changes
May 13, 2024
| @@ -131,28 +138,55 @@ internal class TreeViewTraversalTest { | |||
| @Test | |||
| fun `M default to view mapper and continue W traverse { mapper for view type not provided }`( | |||
Member
There was a problem hiding this comment.
I think the description for this test may be wrong, since the test is traversing a single view
0xnm
approved these changes
May 13, 2024
| private val colorStringFormatter: ColorStringFormatter = DefaultColorStringFormatter | ||
| private val viewBoundsResolver: ViewBoundsResolver = DefaultViewBoundsResolver | ||
| private val drawableToColorMapper: DrawableToColorMapper = DrawableToColorMapper.getDefault() | ||
| private val drawableToColorMapper: DrawableToColorMapper = DrawableToColorMapper.getDefault(InternalLogger.UNBOUND) |
Member
There was a problem hiding this comment.
It means no telemetry will be sent for this one, because InternalLogger.UNBOUND is not bound to any SDK instance (and hence to the RUM feature). Is it supposed to be like that?
xgouchet
force-pushed
the
xgouchet/RUM-4103/add_sr_coverage_telemetry
branch
from
May 13, 2024 08:50
4ea7ef9 to
a5fff47
Compare
xgouchet
force-pushed
the
xgouchet/RUM-4103/add_sr_coverage_telemetry
branch
from
May 13, 2024 10:31
a5fff47 to
74cf7ef
Compare
0xnm
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds some telemetry when a View or Drawable cannot be converted into Session Replay data.
Motivation
We need to better understand the UI features used by our customer that we don't have support of yet.