RUM-4413 Add telemetry on SR resources track#2027
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2027 +/- ##
===========================================
+ Coverage 83.17% 83.34% +0.18%
===========================================
Files 486 486
Lines 17633 17670 +37
Branches 2680 2687 +7
===========================================
+ Hits 14665 14727 +62
+ Misses 2232 2201 -31
- Partials 736 742 +6
|
maciejburda
approved these changes
May 10, 2024
jonathanmos
approved these changes
May 12, 2024
jonathanmos
reviewed
May 12, 2024
| /** | ||
| * Session Replay Resources sub-feature name. | ||
| */ | ||
| const val SESSION_REPLAY_RESOURCES_FEATURE_NAME: String = "session-replay-resources" |
Member
There was a problem hiding this comment.
By adding this here, the feature name for Resources is now defined in two places - in Feature and also in the feature itself. I notice that this is also the case for Session Replay. Do we want to consolidate both of them to use only the constants from Feature and have a SST?
0xnm
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In order to better read the performance of the Image Resource upload for Session Replay, we add the telemetry on batch deleted/closed/expired with a dedicated track name.