Skip to content

RUM-4369: Support additional properties in Telemetry Error events#2025

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-4369/support-additional-properties-in-telemetry-errors
May 6, 2024
Merged

RUM-4369: Support additional properties in Telemetry Error events#2025
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-4369/support-additional-properties-in-telemetry-errors

Conversation

@0xnm

@0xnm 0xnm commented May 3, 2024

Copy link
Copy Markdown
Member

What does this PR do?

This PR adds support for the additionalProperties for the TelemetryErrorEvent. They are already supported in TelemetryDebugEvent, but were missing for the errors.

Code is updated to propagate these additional properties to the telemetry.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners May 3, 2024 15:08
@codecov-commenter

codecov-commenter commented May 3, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 83.21%. Comparing base (3d0a4d2) to head (9b200e9).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2025      +/-   ##
===========================================
- Coverage    83.31%   83.21%   -0.10%     
===========================================
  Files          485      486       +1     
  Lines        17671    17680       +9     
  Branches      2685     2687       +2     
===========================================
- Hits         14722    14712      -10     
- Misses        2213     2232      +19     
  Partials       736      736
Files Coverage Δ
...lin/com/datadog/android/rum/internal/RumFeature.kt 93.90% <100.00%> (+1.24%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 86.71% <100.00%> (+0.95%) ⬆️
...tlin/com/datadog/android/core/SdkInternalLogger.kt 90.11% <87.50%> (-2.11%) ⬇️
...android/rum/internal/monitor/AdvancedRumMonitor.kt 66.67% <66.67%> (ø)
...ndroid/telemetry/internal/TelemetryEventHandler.kt 79.59% <50.00%> (+1.47%) ⬆️
...om/datadog/android/telemetry/internal/Telemetry.kt 11.11% <0.00%> (-1.39%) ⬇️

... and 25 files with indirect coverage changes

@0xnm
0xnm merged commit ddf2286 into develop May 6, 2024
@0xnm
0xnm deleted the nogorodnikov/rum-4369/support-additional-properties-in-telemetry-errors branch May 6, 2024 06:52
@xgouchet xgouchet added this to the 2.10.x milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.10.x

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @codecov-commenter @xgouchet