RUM-1520 create RUM Feature Integration Tests#2004
Merged
Conversation
0xnm
approved these changes
Apr 22, 2024
| // Then | ||
| val eventsWritten = stubSdkCore.eventsWritten(Feature.RUM_FEATURE_NAME) | ||
| StubEventsAssert.assertThat(eventsWritten) | ||
| .hasRumEvent(1) { |
Member
There was a problem hiding this comment.
minor: maybe we need to make use of the named argument here, otherwise it is hard to understand what 1 means here without looking at the assertion method implementation details.
| val result = GlobalRumMonitor.get(stubSdkCore) | ||
|
|
||
| // Then | ||
| // We use reflexion because that class is marked internal |
Member
There was a problem hiding this comment.
Suggested change
| // We use reflexion because that class is marked internal | |
| // We use reflection because that class is marked internal |
although reflexion can also exist in English - archaic spelling of reflection 😄
Contributor
Author
There was a problem hiding this comment.
Yeah I always struggle between the french and english spellings :/
Comment on lines
+27
to
+45
| fun hasSessionType(sessionType: String) { | ||
| hasField("session.type", sessionType) | ||
| } | ||
|
|
||
| fun hasSource(source: String) { | ||
| hasField("source", source) | ||
| } | ||
|
|
||
| fun hasType(type: String) { | ||
| hasField("type", type) | ||
| } | ||
|
|
||
| fun hasViewUrl(viewUrl: String) { | ||
| hasField("view.url", viewUrl) | ||
| } | ||
|
|
||
| fun hasViewName(viewName: String) { | ||
| hasField("view.name", viewName) | ||
| } |
Member
There was a problem hiding this comment.
these methods also should return this for the API consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a first draft of the RUM Feature Integration tests.
It's not exhaustive yet as there's a lot to cover, but it provides a first basis to expand upon