Conversation
0xnm
force-pushed
the
nogorodnikov/rum-4118/dont-mark-internal-extension-functions-for-3rd-party-types-as-3rd-party
branch
from
April 17, 2024 13:06
462b42b to
4f4ebb2
Compare
0xnm
force-pushed
the
nogorodnikov/rum-4118/dont-mark-internal-extension-functions-for-3rd-party-types-as-3rd-party
branch
from
April 17, 2024 13:29
4f4ebb2 to
9263a25
Compare
mariusc83
approved these changes
Apr 17, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1996 +/- ##
===========================================
- Coverage 83.66% 83.65% -0.01%
===========================================
Files 488 488
Lines 17770 17730 -40
Branches 2663 2661 -2
===========================================
- Hits 14867 14832 -35
+ Misses 2178 2177 -1
+ Partials 725 721 -4 |
0xnm
deleted the
nogorodnikov/rum-4118/dont-mark-internal-extension-functions-for-3rd-party-types-as-3rd-party
branch
April 17, 2024 14:30
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix for the long-standing issue:
UnsafeThirdPartyFunctionCallwas marking internal extension functions for third-party types as third-party functions, which is wrong. This PR fixes that by checking the declaration package for the function in addition to its container.Review checklist (to be filled by reviewers)