Skip to content

Update copyright#1992

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/update-copyright-170424
Apr 17, 2024
Merged

Update copyright#1992
0xnm merged 1 commit into
developfrom
nogorodnikov/update-copyright-170424

Conversation

@0xnm

@0xnm 0xnm commented Apr 17, 2024

Copy link
Copy Markdown
Member

What does this PR do?

This PR updates copyright in the project files: in some places it was missing, it some places it was outdated.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners April 17, 2024 09:17

@xgouchet xgouchet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, Maybe we could have some static analysis job that verifies all files have a valid copyright?

@codecov-commenter

codecov-commenter commented Apr 17, 2024

Copy link
Copy Markdown

Codecov Report

Merging #1992 (0af6e7a) into develop (18967d7) will decrease coverage by 0.10%.
Report is 8 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1992      +/-   ##
===========================================
- Coverage    83.66%   83.57%   -0.10%     
===========================================
  Files          488      488              
  Lines        17770    17738      -32     
  Branches      2663     2658       -5     
===========================================
- Hits         14867    14823      -44     
- Misses        2178     2193      +15     
+ Partials       725      722       -3     
Files Coverage Δ
...atadog/android/core/internal/utils/ThrowableExt.kt 100.00% <ø> (ø)
...internal/instrumentation/gestures/GesturesUtils.kt 90.91% <ø> (ø)
...nternal/tracking/OreoFragmentLifecycleCallbacks.kt 90.00% <ø> (ø)
...roid/webview/internal/rum/WebViewRumEventMapper.kt 100.00% <ø> (ø)

... and 27 files with indirect coverage changes

@0xnm

0xnm commented Apr 17, 2024

Copy link
Copy Markdown
Member Author

@xgouchet Good suggestion, I created a ticket for that. Thanks for comment from @jonathanmos here, I realized that Android Studio by some reason doesn't add copyright to the new files (even though copyright is declared in the editor settings).

@0xnm
0xnm merged commit 71dab01 into develop Apr 17, 2024
@0xnm
0xnm deleted the nogorodnikov/update-copyright-170424 branch April 17, 2024 13:38
@xgouchet xgouchet added this to the 2.9.X milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants