RUM-3597: Start sending batches immediately after feature is initialized#1991
Merged
0xnm merged 1 commit intoApr 17, 2024
Conversation
xgouchet
approved these changes
Apr 17, 2024
mariusc83
approved these changes
Apr 17, 2024
mariusc83
reviewed
Apr 17, 2024
0xnm
force-pushed
the
nogorodnikov/rum-3597/start-sending-batches-immediately-after-feature-initialization
branch
from
April 17, 2024 13:41
4371143 to
8998bda
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1991 +/- ##
===========================================
+ Coverage 83.64% 83.74% +0.10%
===========================================
Files 488 488
Lines 17771 17773 +2
Branches 2666 2666
===========================================
+ Hits 14863 14883 +20
+ Misses 2183 2167 -16
+ Partials 725 723 -2
|
0xnm
force-pushed
the
nogorodnikov/rum-3597/start-sending-batches-immediately-after-feature-initialization
branch
from
April 17, 2024 14:33
8998bda to
ae36cdc
Compare
0xnm
deleted the
nogorodnikov/rum-3597/start-sending-batches-immediately-after-feature-initialization
branch
April 17, 2024 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This change removes initial delay for start sending batches, now they the first upload will be triggered right after the feature is initialized instead of waiting for some delay.
This allows to submit more data in case if application is crashing early.
The downside is that there is a chance that first batch uploaded won't be sent to the batch upload metrics telemetry, because RUM monitor may be not ready yet, but this is acceptable.
Review checklist (to be filled by reviewers)