RUM-4084 Synchronize SR info with webviews#1990
Merged
Merged
Conversation
0xnm
reviewed
Apr 17, 2024
Comment on lines
+47
to
+50
| if (!sessionReplayEnabled) { | ||
| // RUM-4084 disable webview SR if host app doesn't have SR | ||
| // dd.remove(DD_REPLAY_STATS) | ||
| } |
Member
There was a problem hiding this comment.
Empty block. Should the line be uncommented?
xgouchet
force-pushed
the
xgouchet/RUM-4084/sr_browser_sync
branch
from
April 17, 2024 08:40
f9f810a to
45a56fa
Compare
0xnm
approved these changes
Apr 17, 2024
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes some discrepancies between the Webview and host app content regarding Session Replay :
_dd.session.planfield has been deprecated and should be removedsession.has_replayand_dd.replay_statsfields should be discarded from the webview RUM event if SR is disable in the host application, to avoid orphan SR sessions