Update Detekt API version used to 1.23.0#1988
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1988 +/- ##
===========================================
- Coverage 83.68% 83.61% -0.07%
===========================================
Files 487 487
Lines 17736 17741 +5
Branches 2663 2663
===========================================
- Hits 14842 14834 -8
- Misses 2167 2180 +13
Partials 727 727 |
0xnm
force-pushed
the
nogorodnikov/update-detekt-api-version
branch
from
April 15, 2024 12:34
1dec6d4 to
0b4ddad
Compare
xgouchet
approved these changes
Apr 15, 2024
Contributor
|
Note We also need to update the shared pipeline to 1.23.0 in |
Member
Author
|
@xgouchet It is 1.23.4 there in the latest version. Or you mean something else? Anyway, with this PR tests are passing on macOS, but failing in the CI (Linux) container, so I probably keep this PR on hold for now. |
jonathanmos
approved these changes
Apr 17, 2024
0xnm
force-pushed
the
nogorodnikov/update-detekt-api-version
branch
3 times, most recently
from
April 18, 2024 10:28
c2afaad to
d0d444f
Compare
0xnm
force-pushed
the
nogorodnikov/update-detekt-api-version
branch
from
April 18, 2024 10:34
d0d444f to
b658564
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I noticed some Kotlin 1.7 artifacts downloaded for the test classpath and they were coming from Detekt 1.22.0.
This PR updates Detekt to 1.23.0 to be better aligned with the version we use for the checks (1.23.4) and to stop Kotlin 1.7 artifacts being downloaded.
Detekt 1.23.4 is not used because it will bring Kotlin 1.9, this is not what we want.
Detekt changelog is here.
Review checklist (to be filled by reviewers)