RUM-3905: Use custom naming for threads created inside SDK#1987
Merged
0xnm merged 1 commit intoApr 17, 2024
Merged
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-3905/custom-naming-for-threads-created-by-sdk
branch
from
April 15, 2024 11:08
78959c0 to
f74015f
Compare
xgouchet
approved these changes
Apr 15, 2024
0xnm
force-pushed
the
nogorodnikov/rum-3905/custom-naming-for-threads-created-by-sdk
branch
3 times, most recently
from
April 15, 2024 11:50
cf78d24 to
bd89fed
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1987 +/- ##
===========================================
- Coverage 83.68% 83.66% -0.02%
===========================================
Files 487 488 +1
Lines 17736 17770 +34
Branches 2663 2663
===========================================
+ Hits 14842 14867 +25
- Misses 2167 2178 +11
+ Partials 727 725 -2
|
jonathanmos
approved these changes
Apr 17, 2024
0xnm
force-pushed
the
nogorodnikov/rum-3905/custom-naming-for-threads-created-by-sdk
branch
from
April 17, 2024 08:18
bd89fed to
18967d7
Compare
0xnm
deleted the
nogorodnikov/rum-3905/custom-naming-for-threads-created-by-sdk
branch
April 17, 2024 08:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces custom
ThreadFactoryfor the threads created by SDK. Its only purpose is to name them in formatdatadog-{context}-threadN, where context may be feature track, etc.This will give us a better visibility in telemetry (the necessary attribute was added for the executor-related events) and also allows to better navigate profiling data.
Review checklist (to be filled by reviewers)