RUM-3992 Prevent crash in JankStats listener#1981
Merged
Merged
Conversation
0xnm
approved these changes
Apr 10, 2024
xgouchet
force-pushed
the
xgouchet/RUM-3992/jank_stats_crash
branch
from
April 10, 2024 14:26
e6bedcb to
942d559
Compare
xgouchet
force-pushed
the
xgouchet/RUM-3992/jank_stats_crash
branch
from
April 11, 2024 07:04
942d559 to
eca3a98
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1981 +/- ##
===========================================
- Coverage 83.71% 83.61% -0.10%
===========================================
Files 487 487
Lines 17737 17695 -42
Branches 2663 2656 -7
===========================================
- Hits 14848 14795 -53
Misses 2170 2170
- Partials 719 730 +11
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1976
In Android N (until Android P included), the internal View. findFrameMetricsObserver() method did not check the nullability of the
mFrameMetricsObserversfield, leading to possible NPE when trying to remove a listener that wasn't yet added.Motivation
Some customer have seen a crash with an NPE thrown from the Android View when removing the
FrameMetricsListenervia theJankStatslibrary.Even though all versions of the official Android View are written in a way that NPE should never happen, those crash still occurred.