RUM-3250 Provide Otel bundle with logs feature#1979
Merged
mariusc83 merged 1 commit intoApr 10, 2024
Merged
Conversation
mariusc83
force-pushed
the
mconstantin/rum-3250/provide-otel-bundle-with-logs-feature
branch
3 times, most recently
from
April 9, 2024 14:31
ad27d4e to
2a1f9fc
Compare
mariusc83
marked this pull request as ready for review
April 9, 2024 14:31
mariusc83
force-pushed
the
mconstantin/rum-3250/provide-otel-bundle-with-logs-feature
branch
from
April 9, 2024 14:51
2a1f9fc to
acbc65e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/otel-support #1979 +/- ##
========================================================
+ Coverage 60.29% 60.36% +0.06%
========================================================
Files 807 808 +1
Lines 30183 30188 +5
Branches 4945 4945
========================================================
+ Hits 18198 18220 +22
+ Misses 10766 10749 -17
Partials 1219 1219
|
0xnm
previously approved these changes
Apr 9, 2024
Comment on lines
+55
to
+58
| val traceContext: MutableMap<String, Any?> = mutableMapOf() | ||
| argumentCaptor<(MutableMap<String, Any?>) -> Unit> { | ||
| verify(mockSdkCore).updateFeatureContext(eq(Feature.TRACING_FEATURE_NAME), capture()) | ||
| firstValue.invoke(traceContext) |
Member
There was a problem hiding this comment.
traceContext can be directly in lambda
Suggested change
| val traceContext: MutableMap<String, Any?> = mutableMapOf() | |
| argumentCaptor<(MutableMap<String, Any?>) -> Unit> { | |
| verify(mockSdkCore).updateFeatureContext(eq(Feature.TRACING_FEATURE_NAME), capture()) | |
| firstValue.invoke(traceContext) | |
| argumentCaptor<(MutableMap<String, Any?>) -> Unit> { | |
| verify(mockSdkCore).updateFeatureContext(eq(Feature.TRACING_FEATURE_NAME), capture()) | |
| val traceContext: MutableMap<String, Any?> = mutableMapOf() | |
| firstValue.invoke(traceContext) |
mariusc83
force-pushed
the
mconstantin/rum-3250/provide-otel-bundle-with-logs-feature
branch
from
April 9, 2024 15:37
acbc65e to
9dae312
Compare
0xnm
approved these changes
Apr 9, 2024
xgouchet
approved these changes
Apr 10, 2024
|
|
||
| AgentScope activateNext(AgentSpan span); | ||
|
|
||
| @Nullable |
Contributor
There was a problem hiding this comment.
Note
That is a nice idea, but shouldn't we add @Nullable/@NonNull to all methods' return value and arguments, just to be safe?
Member
Author
There was a problem hiding this comment.
This is a huge task and should not be part of this epic, for now I am adding this whenever I interact with the Java code from Kotlin because this is where the problem can come from. As a rule of thumb we should always check the Java code when calling from Kotlin to make sure we are safe.
mariusc83
deleted the
mconstantin/rum-3250/provide-otel-bundle-with-logs-feature
branch
April 10, 2024 08:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)