Update OkHttp to 4.12.0#1975
Merged
Merged
Conversation
0xnm
changed the base branch from
develop
to
nogorodnikov/update-kotlin-to-1.8.22
April 8, 2024 14:05
0xnm
force-pushed
the
nogorodnikov/update-okhttp-to-4.12.0
branch
2 times, most recently
from
April 8, 2024 14:33
1b24ca1 to
4797af9
Compare
mariusc83
reviewed
Apr 8, 2024
| androidx.annotation:annotation:1.3.0 : 30 Kb | ||
| com.google.code.gson:gson:2.10.1 : 276 Kb | ||
| org.jetbrains.kotlin:kotlin-stdlib-common:1.8.22 : 216 Kb | ||
| org.jetbrains.kotlin:kotlin-stdlib-common:1.9.10 : 219 Kb |
Member
There was a problem hiding this comment.
you are updating to 1.9 here but in the prev PR you mentioned that this is not yet recommended. Are we safe here ?
Member
Author
There was a problem hiding this comment.
Well, we don't update compiler, so in theory it is safe, but I'm going to keep this PR on hold anyway, because of Kotlin 1.9 stdlib usage. Once we are confirmed that we are fine with Kotlin 1.9, we can merge this one.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1975 +/- ##
==========================================
Coverage ? 70.07%
==========================================
Files ? 726
Lines ? 26989
Branches ? 4526
==========================================
Hits ? 18910
Misses ? 6814
Partials ? 1265 |
xgouchet
approved these changes
Apr 9, 2024
jonathanmos
approved these changes
Apr 17, 2024
Contributor
|
Note The Kotlin dependency has been upgraded to 1.9.10, I think we can rebase and merge this PR now :) |
0xnm
force-pushed
the
nogorodnikov/update-okhttp-to-4.12.0
branch
from
August 12, 2024 13:39
4797af9 to
97c4a01
Compare
mariusc83
approved these changes
Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates OkHttp version to 4.12.0, changelog is here https://square.github.io/okhttp/changelogs/changelog_4x/
Review checklist (to be filled by reviewers)