RUM-3486: Remove non-ASCII characters from test names#1973
Merged
0xnm merged 1 commit intoApr 9, 2024
Merged
Conversation
fuzzybinary
approved these changes
Apr 8, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1973 +/- ##
===========================================
- Coverage 83.58% 83.38% -0.20%
===========================================
Files 489 489
Lines 17932 17925 -7
Branches 2671 2670 -1
===========================================
- Hits 14987 14945 -42
- Misses 2226 2249 +23
- Partials 719 731 +12 |
mariusc83
approved these changes
Apr 8, 2024
0xnm
deleted the
nogorodnikov/rum-3486/remove-non-ascii-characters-from-test-names
branch
April 9, 2024 07:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes non-ASCII characters from test names to be compatible with Kotlin 1.8.20+, see https://youtrack.jetbrains.com/issue/KT-60748 for more details.
Review checklist (to be filled by reviewers)