Conversation
…teraction targets
xgouchet
approved these changes
Apr 5, 2024
xgouchet
left a comment
xgouchet
left a comment
Contributor
There was a problem hiding this comment.
Nice catch !
And I think you won the longest branch name contest too :D
mariusc83
approved these changes
Apr 8, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1969 +/- ##
===========================================
- Coverage 83.35% 83.33% -0.03%
===========================================
Files 489 489
Lines 17900 17897 -3
Branches 2669 2669
===========================================
- Hits 14920 14913 -7
- Misses 2243 2245 +2
- Partials 737 739 +2
|
0xnm
deleted the
nogorodnikov/rum-3868/dont-traverse-non-visible-viewgroups-for-searching-user-interaction-targets
branch
April 8, 2024 09:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This a fix for the following bug: let's imagine we have a container view and a child view in this container, both are visible. If we set
View.GONEorView.INVISIBLEfor the container view, both views won't be visible, but if we click on the place where child view would be rendered, the tap will be reported.This happens because when we hide container view, child view still have a visibility
View.VISIBLEdespite not participating in rendering (if parent group hasView.INVISIBLE) or even in the layout process (if parent group hasView.GONE).This means we need to take into account the visibility of the view groups as well when we are searching for the user interaction target.
Note: child cannot be shown without parent shown, meaning even if we have
View.INVISIBLEfor parent container switching visibility for child view has no effect (at least for built-in view groups as I tested).Review checklist (to be filled by reviewers)