Skip to content

Fix flaky tests#1967

Merged
xgouchet merged 5 commits into
developfrom
xgouchet/flaky_tests
Apr 4, 2024
Merged

Fix flaky tests#1967
xgouchet merged 5 commits into
developfrom
xgouchet/flaky_tests

Conversation

@xgouchet

@xgouchet xgouchet commented Apr 4, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

This commit attemps to fix several tests that are regularly flaky in CI

@xgouchet
xgouchet requested review from a team as code owners April 4, 2024 11:39
@Test
fun `𝕄 stop all features 𝕎 stop()`(
@StringForgery fakeFeatureNames: List<String>
@StringForgery fakeFeatureNames: Set<String>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already here #1965 :)

@xgouchet
xgouchet force-pushed the xgouchet/flaky_tests branch from 3187e7c to a1cf20b Compare April 4, 2024 13:19
@codecov-commenter

codecov-commenter commented Apr 4, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.33%. Comparing base (fb5a1de) to head (a1cf20b).
⚠️ Report is 3475 commits behind head on develop.

Files with missing lines Patch % Lines
...core/internal/system/DefaultAndroidInfoProvider.kt 75.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1967      +/-   ##
===========================================
+ Coverage    83.31%   83.33%   +0.01%     
===========================================
  Files          489      489              
  Lines        17883    17875       -8     
  Branches      2666     2669       +3     
===========================================
- Hits         14899    14895       -4     
+ Misses        2240     2239       -1     
+ Partials       744      741       -3     
Files with missing lines Coverage Δ
...core/internal/system/DefaultAndroidInfoProvider.kt 79.59% <75.00%> (-5.19%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xgouchet
xgouchet merged commit 337e299 into develop Apr 4, 2024
@xgouchet
xgouchet deleted the xgouchet/flaky_tests branch April 4, 2024 14:53
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants