Skip to content

Update actions for running CodeQL workflow#1966

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/update-actions-for-running-codeql-workflow
Apr 4, 2024
Merged

Update actions for running CodeQL workflow#1966
0xnm merged 1 commit into
developfrom
nogorodnikov/update-actions-for-running-codeql-workflow

Conversation

@0xnm

@0xnm 0xnm commented Apr 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do?

This PR updates actions for running CodeQL workflow to address the following warnings (see, for example, here):

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-java@v1, github/codeql-action/init@v2, gradle/[email protected], github/codeql-action/analyze@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-java@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

CodeQL Action v2 will be deprecated on December 5th, 2024. Please update all occurrences of the CodeQL Action in your workflow files to v3. For more information, see https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners April 4, 2024 07:55
@0xnm
0xnm force-pushed the nogorodnikov/update-actions-for-running-codeql-workflow branch 3 times, most recently from bbe5680 to db28d2d Compare April 4, 2024 08:01
@0xnm
0xnm force-pushed the nogorodnikov/update-actions-for-running-codeql-workflow branch from db28d2d to ab1bf0a Compare April 4, 2024 08:05
@codecov-commenter

codecov-commenter commented Apr 4, 2024

Copy link
Copy Markdown

Codecov Report

Merging #1966 (ab1bf0a) into develop (fb5a1de) will increase coverage by 0.13%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1966      +/-   ##
===========================================
+ Coverage    83.31%   83.44%   +0.13%     
===========================================
  Files          489      489              
  Lines        17883    17878       -5     
  Branches      2666     2664       -2     
===========================================
+ Hits         14899    14918      +19     
+ Misses        2240     2232       -8     
+ Partials       744      728      -16

see 30 files with indirect coverage changes

@0xnm
0xnm merged commit 450ceb6 into develop Apr 4, 2024
@0xnm
0xnm deleted the nogorodnikov/update-actions-for-running-codeql-workflow branch April 4, 2024 13:22
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.8.x

Development

Successfully merging this pull request may close these issues.

3 participants

@0xnm @codecov-commenter @xgouchet