Skip to content

Fix flakey DatadogCore test#1965

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/fix-flaky-datadogcore-test-030424
Apr 4, 2024
Merged

Fix flakey DatadogCore test#1965
0xnm merged 1 commit into
developfrom
nogorodnikov/fix-flaky-datadogcore-test-030424

Conversation

@0xnm

@0xnm 0xnm commented Apr 3, 2024

Copy link
Copy Markdown
Member

What does this PR do?

We could have duplicate feature names if using List.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners April 3, 2024 14:41
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1965 (3ed1718) into develop (fb5a1de) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1965      +/-   ##
===========================================
+ Coverage    83.31%   83.35%   +0.04%     
===========================================
  Files          489      489              
  Lines        17883    17876       -7     
  Branches      2666     2663       -3     
===========================================
+ Hits         14899    14900       +1     
- Misses        2240     2241       +1     
+ Partials       744      735       -9     

see 30 files with indirect coverage changes

@0xnm 0xnm mentioned this pull request Apr 4, 2024
@0xnm
0xnm merged commit 5835c56 into develop Apr 4, 2024
@0xnm
0xnm deleted the nogorodnikov/fix-flaky-datadogcore-test-030424 branch April 4, 2024 13:22
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants