RUM-3757: Make sure error.threads always have content from error.stack#1964
Merged
0xnm merged 1 commit intoApr 4, 2024
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-3757/make-sure-error-threads-contains-info-from-error-stack
branch
from
April 3, 2024 13:48
3f4b119 to
dac8d88
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1964 +/- ##
===========================================
+ Coverage 83.31% 83.38% +0.07%
===========================================
Files 489 489
Lines 17883 17880 -3
Branches 2666 2663 -3
===========================================
+ Hits 14899 14909 +10
+ Misses 2240 2234 -6
+ Partials 744 737 -7
|
mariusc83
approved these changes
Apr 4, 2024
xgouchet
approved these changes
Apr 4, 2024
0xnm
deleted the
nogorodnikov/rum-3757/make-sure-error-threads-contains-info-from-error-stack
branch
April 4, 2024 13:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It seems sometimes it is possible to have result of
Thread.getAllStackTraces()without the thread impacted by ANR/crashing thread info (or without attached stacktrace, not sure here). It is not clear why it happens, but we clearly can see such issues in the dashboard, whenerror.stackis not found amongerror.threadsreported (meaningerror.threadsdoesn't have thread for which we reportingerror.stack).This change fixes that by making sure ANR thread/crashing thread is always in the
error.threads- we will always add it to the list, not relying on the match amongThread.getAllStackTraces()results.Review checklist (to be filled by reviewers)