Fix message when writer is NoOp#1963
Merged
Merged
Conversation
0xnm
reviewed
Apr 3, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
nice catch! I added a suggestion.
| level = InternalLogger.Level.INFO, | ||
| target = InternalLogger.Target.USER, | ||
| messageBuilder = { WRITE_OPERATION_IGNORED } | ||
| ) |
Member
There was a problem hiding this comment.
suggestion: we probably should also call onSuccess/onError here (don't know which one makes more sense), because at least for the RumViewScope until sum(pending) == 0 it won't be marked as complete and thus garbage collected. We may have the case when there is NoOpDataWriter here and RUM pipeline working if session is not tracked, I believe.
xgouchet
force-pushed
the
xgouchet/no_op_writer_rum_expired
branch
from
April 3, 2024 12:00
acf1e06 to
133f4eb
Compare
0xnm
approved these changes
Apr 3, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1963 +/- ##
===========================================
+ Coverage 83.24% 83.29% +0.04%
===========================================
Files 489 489
Lines 17857 17837 -20
Branches 2661 2664 +3
===========================================
- Hits 14865 14856 -9
+ Misses 2264 2245 -19
- Partials 728 736 +8
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This avoids misleading logs when a RUM session is expired and the writer becomes no op (it returns false on write).
Motivation
Avoid noise and misleading noise in logcat for customer, and provide a more relevant explanation