Fix flaky TodoWithoutTask tests#1962
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1962 +/- ##
===========================================
+ Coverage 83.24% 83.37% +0.13%
===========================================
Files 489 489
Lines 17857 17827 -30
Branches 2661 2654 -7
===========================================
- Hits 14865 14863 -2
+ Misses 2264 2243 -21
+ Partials 728 721 -7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Regex
[A-Z]+-\\d{1,8}may generate something likeABC-0because of thed{1,8}, and this will fail some tests, because 0 as a task number is not allowed.This PR fixes that.
Note: In theory it is possible to have something like
ABC-012, but generating012and avoiding to have all zeros at the same time requires using matching groups/negative lookaheads, which is not supported byForge.Review checklist (to be filled by reviewers)