RUM-2910: Report time since the application start for crashes in RUM#1961
Merged
0xnm merged 3 commits intoApr 3, 2024
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1961 +/- ##
===========================================
+ Coverage 83.24% 83.31% +0.07%
===========================================
Files 489 489
Lines 17857 17860 +3
Branches 2661 2660 -1
===========================================
+ Hits 14865 14880 +15
+ Misses 2264 2252 -12
Partials 728 728
|
0xnm
marked this pull request as ready for review
April 3, 2024 07:23
xgouchet
approved these changes
Apr 3, 2024
mariusc83
approved these changes
Apr 3, 2024
| ) | ||
| }.ifEmpty { null } | ||
| }.ifEmpty { null }, | ||
| timeSinceAppStart = event.timeSinceAppStartNs?.let { TimeUnit.NANOSECONDS.toMillis(it) } |
Member
There was a problem hiding this comment.
maybe you should extract this in a function ?
0xnm
deleted the
nogorodnikov/rum-2910/report-time-since-app-start-for-crashes
branch
April 3, 2024 09:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the following:
This is achieved by introducing
error.time_since_app_startattribute (in milliseconds). Application start is defined as the start of the application process (the same definition as for theApplicationLaunchview).Also this PR moves application start time provider to the core module, because:
DatadogCoreclass loading, which happens beforeRumFeatureclass loading and thus should give more precise timestamp.This PR doesn't add support of reporting the similar time for the fatal ANRs, because additional development is needed there to keep somehow application start time between application launches.
Review checklist (to be filled by reviewers)