Skip to content

Disable flaky Session Replay test#1957

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/disable-flaky-session-replay-test
Apr 2, 2024
Merged

Disable flaky Session Replay test#1957
0xnm merged 1 commit into
developfrom
nogorodnikov/disable-flaky-session-replay-test

Conversation

@0xnm

@0xnm 0xnm commented Apr 2, 2024

Copy link
Copy Markdown
Member

What does this PR do?

This changes disables flaky Session Replay test and also puts @Test annotations back (they don't need to be removed when adding @Ignore annotation).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners April 2, 2024 08:48
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #1957 (9491174) into develop (0f0d085) will decrease coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1957      +/-   ##
===========================================
- Coverage    83.21%   83.19%   -0.02%     
===========================================
  Files          483      483              
  Lines        17584    17565      -19     
  Branches      2605     2601       -4     
===========================================
- Hits         14632    14613      -19     
+ Misses        2257     2250       -7     
- Partials       695      702       +7     

see 30 files with indirect coverage changes

@0xnm
0xnm merged commit 8fce9e6 into develop Apr 2, 2024
@0xnm
0xnm deleted the nogorodnikov/disable-flaky-session-replay-test branch April 2, 2024 09:51
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants