Remove Runtime shutdown hook when SDK instance is stopped#1956
Merged
0xnm merged 1 commit intoApr 2, 2024
Merged
Conversation
xgouchet
approved these changes
Apr 2, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1956 +/- ##
===========================================
- Coverage 83.21% 83.16% -0.05%
===========================================
Files 483 483
Lines 17584 17566 -18
Branches 2605 2603 -2
===========================================
- Hits 14632 14608 -24
+ Misses 2257 2254 -3
- Partials 695 704 +9
|
mariusc83
approved these changes
Apr 2, 2024
0xnm
deleted the
nogorodnikov/remove-runtime-shutdown-hook-when-stopping-sdk-instance
branch
April 2, 2024 13:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Otherwise it is possible to have a memory leak when SDK instance is stopped, because reference to the SDK instance still exists through the hook runnable.
Review checklist (to be filled by reviewers)