Skip to content

Improve todo detekt rule#1955

Merged
xgouchet merged 3 commits into
developfrom
xgouchet/reliability/improve_todo_detekt_rule
Apr 2, 2024
Merged

Improve todo detekt rule#1955
xgouchet merged 3 commits into
developfrom
xgouchet/reliability/improve_todo_detekt_rule

Conversation

@xgouchet

@xgouchet xgouchet commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

Improve our detekt rule around TODO comments:

  • Ensure we catch all TODO comments
  • Ensure we don't use the TODO RUM-0000 trick to not create a ticket in our backlog
  • Update the old referenced tickets (RUMM and REPLAY) with the new RUM prefix

@xgouchet
xgouchet requested review from a team as code owners March 29, 2024 18:22
@xgouchet
xgouchet force-pushed the xgouchet/reliability/improve_todo_detekt_rule branch from a356cda to f7782bf Compare March 30, 2024 08:33
@xgouchet
xgouchet force-pushed the xgouchet/reliability/improve_todo_detekt_rule branch from f7782bf to 03d8d4e Compare March 30, 2024 09:21
@codecov-commenter

codecov-commenter commented Mar 30, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1955 (03d8d4e) into develop (5e76858) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1955      +/-   ##
===========================================
- Coverage    83.26%   83.21%   -0.05%     
===========================================
  Files          486      483       -3     
  Lines        17586    17572      -14     
  Branches      2605     2605              
===========================================
- Hits         14642    14622      -20     
- Misses        2248     2252       +4     
- Partials       696      698       +2
Files Coverage Δ
.../main/kotlin/com/datadog/android/_InternalProxy.kt 63.64% <ø> (ø)
...ain/kotlin/com/datadog/android/core/DatadogCore.kt 83.85% <ø> (ø)
...n/com/datadog/android/core/internal/CoreFeature.kt 86.69% <ø> (ø)
...tadog/android/core/internal/NoOpContextProvider.kt 3.45% <ø> (ø)
...in/com/datadog/android/core/internal/SdkFeature.kt 91.55% <ø> (ø)
...l/net/info/BroadcastReceiverNetworkInfoProvider.kt 93.94% <100.00%> (+0.06%) ⬆️
...e/internal/net/info/CallbackNetworkInfoProvider.kt 95.24% <ø> (ø)
...droid/core/internal/persistence/AbstractStorage.kt 100.00% <ø> (ø)
...al/persistence/file/batch/BatchFileOrchestrator.kt 94.94% <ø> (ø)
...roid/core/internal/user/DatadogUserInfoProvider.kt 100.00% <ø> (ø)
... and 34 more

... and 15 files with indirect coverage changes

@xgouchet
xgouchet merged commit 0f0d085 into develop Apr 2, 2024
@xgouchet
xgouchet deleted the xgouchet/reliability/improve_todo_detekt_rule branch April 2, 2024 07:32
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.8.x

Development

Successfully merging this pull request may close these issues.

4 participants

@xgouchet @codecov-commenter @mariusc83 @0xnm