Safe getting of Intent extras#1950
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1950 +/- ##
===========================================
+ Coverage 83.14% 83.18% +0.05%
===========================================
Files 486 486
Lines 17517 17555 +38
Branches 2600 2602 +2
===========================================
+ Hits 14563 14603 +40
+ Misses 2258 2254 -4
- Partials 696 698 +2
|
xgouchet
approved these changes
Mar 28, 2024
mariusc83
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It seems that on old Androids (Android 7 and below) calling
Intent#getExtrassometimes may throw different non-documented exceptions.This PR creates a safe wrapper around this call.
Review checklist (to be filled by reviewers)