RUM-2207 Call RUM error mapper even for crashes#1945
Merged
Conversation
fuzzybinary
force-pushed
the
jward/RUM-2207-crash-event-mapper
branch
2 times, most recently
from
March 27, 2024 14:41
f5fae32 to
84a7b1e
Compare
xgouchet
suggested changes
Mar 27, 2024
Comment on lines
+45
to
+55
| val mappedEvent = errorEventMapper.map(event) | ||
| if (mappedEvent == null) { | ||
| internalLogger.log( | ||
| InternalLogger.Level.WARN, | ||
| InternalLogger.Target.USER, | ||
| { NO_DROPPING_FATAL_ERRORS_WARNING_MESSAGE } | ||
| ) | ||
| event | ||
| } else { | ||
| mappedEvent | ||
| } |
Contributor
There was a problem hiding this comment.
Important
Could you add the tests for this use case ?
Member
Author
There was a problem hiding this comment.
The null case should already be checked (I just added the check for the warning log). I've added a check specifically for making sure the mapper is called when passing a fatal error.
0xnm
approved these changes
Mar 28, 2024
The error event mapper still does not support discarding fatal errors, and a warning is sent if the user returns null for a fatal error in the mapper.
fuzzybinary
force-pushed
the
jward/RUM-2207-crash-event-mapper
branch
from
March 28, 2024 16:03
fa8e4cf to
031f2f3
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1945 +/- ##
===========================================
- Coverage 83.19% 83.14% -0.05%
===========================================
Files 486 486
Lines 17560 17571 +11
Branches 2603 2604 +1
===========================================
Hits 14609 14609
- Misses 2249 2263 +14
+ Partials 702 699 -3
|
xgouchet
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This changes the RUM error event mapper to call the user supplied mapper even for crashes, which it previously excluded.
The error event mapper still does not support discarding fatal errors, and a warning is sent if the user returns null for a fatal error in the mapper.
Review checklist (to be filled by reviewers)