RUM-3670 use backpressured executors#1939
Merged
xgouchet merged 4 commits intoMar 27, 2024
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/2.7.0 #1939 +/- ##
=================================================
- Coverage 83.37% 83.13% -0.25%
=================================================
Files 485 484 -1
Lines 17497 17529 +32
Branches 2598 2591 -7
=================================================
- Hits 14588 14571 -17
- Misses 2203 2256 +53
+ Partials 706 702 -4
|
xgouchet
changed the title
Base automatically changed from
xgouchet/RUM-3670/backpressure_strategy
to
release/2.7.0
March 26, 2024 16:27
xgouchet
force-pushed
the
xgouchet/RUM-3670/backpressured_executors
branch
from
March 26, 2024 16:28
0aefb00 to
b1b4ec6
Compare
0xnm
reviewed
Mar 26, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
I covered so far only production files in a quick look
0xnm
approved these changes
Mar 27, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
lgtm. I left some comments/suggestions, but they are not blocking.
mariusc83
approved these changes
Mar 27, 2024
mariusc83
left a comment
mariusc83
left a comment
Member
There was a problem hiding this comment.
LGTM But I would really like us to think about what I added there as a opened question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Apply the Backpressure strategy and blocking queue to all
ExecutorServices.Additional Notes
Note
We are still using our legacy
LoggingScheduledThreadPoolExecutorfor scheduled tasks (e.g.: uploader, vitals tracking, …). Those will only have one our two tasks in their queue, so it's not as urgent to use the backpressure strategy there. A task (RUM-3704) has been created to keep track of this.Review checklist (to be filled by reviewers)