RUM-3430: Fix application startup time regression#1935
Merged
0xnm merged 1 commit intoMar 27, 2024
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1935 +/- ##
===========================================
+ Coverage 83.31% 83.33% +0.02%
===========================================
Files 481 481
Lines 17412 17413 +1
Branches 2588 2591 +3
===========================================
+ Hits 14506 14510 +4
- Misses 2195 2196 +1
+ Partials 711 707 -4
|
0xnm
marked this pull request as ready for review
March 26, 2024 09:39
xgouchet
approved these changes
Mar 26, 2024
mariusc83
approved these changes
Mar 27, 2024
0xnm
force-pushed
the
nogorodnikov/rum-3430/fix-application-startup-time-regression
branch
from
March 27, 2024 09:41
57369ee to
8b59811
Compare
jonathanmos
approved these changes
Mar 27, 2024
0xnm
deleted the
nogorodnikov/rum-3430/fix-application-startup-time-regression
branch
March 27, 2024 13:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1899.
The change in #1832 broke the application startup time measurement (which was bound to the first RUM event before), because with this change application startup time was dependent on the SDK init moment, which is not the correct way to measure it.
This change brings old behaviour back by ignoring SDK init event.
Review checklist (to be filled by reviewers)