Prevent ConcurrentModificationException when reading feature flags#1925
Merged
0xnm merged 1 commit intoMar 21, 2024
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1925 +/- ##
===========================================
+ Coverage 83.34% 83.39% +0.05%
===========================================
Files 481 481
Lines 17408 17398 -10
Branches 2589 2588 -1
===========================================
Hits 14508 14508
+ Misses 2193 2182 -11
- Partials 707 708 +1
|
xgouchet
approved these changes
Mar 20, 2024
xgouchet
left a comment
xgouchet
left a comment
Contributor
There was a problem hiding this comment.
Nice work, do you think you can add a Unit Test to verify we don't remove this in the future?
mariusc83
approved these changes
Mar 20, 2024
Member
Author
|
@xgouchet Good idea! I will do it then in another PR, because I want this change to be shipped with upcoming release. |
0xnm
deleted the
nogorodnikov/prevent-concurrent-modification-exception-when-reading-feature-flags
branch
March 21, 2024 07:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Small change to prevent
ConcurrentModificationExceptionwhich may happen when feature flags are read duringErrorEventserialization on the worker thread.Review checklist (to be filled by reviewers)