Skip to content

Fix SrImageButtonsMaskUserInputTest#1920

Merged
xgouchet merged 1 commit into
developfrom
xgouchet/sr_image_test_fix
Mar 18, 2024
Merged

Fix SrImageButtonsMaskUserInputTest#1920
xgouchet merged 1 commit into
developfrom
xgouchet/sr_image_test_fix

Conversation

@xgouchet

Copy link
Copy Markdown
Contributor

No description provided.

@xgouchet
xgouchet requested review from a team as code owners March 18, 2024 13:32
@codecov-commenter

codecov-commenter commented Mar 18, 2024

Copy link
Copy Markdown

Codecov Report

Merging #1920 (729576d) into develop (cb8243f) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 729576d differs from pull request most recent head d72908f. Consider uploading reports for the commit d72908f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1920      +/-   ##
===========================================
+ Coverage    83.37%   83.38%   +0.01%     
===========================================
  Files          481      481              
  Lines        17389    17369      -20     
  Branches      2586     2583       -3     
===========================================
- Hits         14497    14482      -15     
+ Misses        2184     2179       -5     
  Partials       708      708              

see 29 files with indirect coverage changes

@xgouchet
xgouchet force-pushed the xgouchet/sr_image_test_fix branch from 729576d to d72908f Compare March 18, 2024 14:34
)

@Test
@Ignore("Flakiness in CI, unsolved yet")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a task created to address this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tasks to migrate the tests to the new pyramid yes

@xgouchet
xgouchet merged commit e0ec676 into develop Mar 18, 2024
@xgouchet
xgouchet deleted the xgouchet/sr_image_test_fix branch March 18, 2024 16:17
@xgouchet xgouchet added this to the 2.7.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants