Skip to content

Adjust ktlint formatting rules#1919

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/adjust-ktlint-formatting-rules
Mar 19, 2024
Merged

Adjust ktlint formatting rules#1919
0xnm merged 1 commit into
developfrom
nogorodnikov/adjust-ktlint-formatting-rules

Conversation

@0xnm

@0xnm 0xnm commented Mar 18, 2024

Copy link
Copy Markdown
Member

What does this PR do?

This PR enabled back indent formatting in ktlint and adds a bit more of configuration to align with what we have right now.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners March 18, 2024 13:24
@codecov-commenter

codecov-commenter commented Mar 18, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #1919 (182cd1d) into develop (cb8243f) will decrease coverage by 0.02%.
Report is 2 commits behind head on develop.
The diff coverage is 60.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1919      +/-   ##
===========================================
- Coverage    83.37%   83.35%   -0.02%     
===========================================
  Files          481      481              
  Lines        17389    17370      -19     
  Branches      2586     2584       -2     
===========================================
- Hits         14497    14478      -19     
+ Misses        2184     2180       -4     
- Partials       708      712       +4
Files Coverage Δ
...ain/kotlin/com/datadog/android/core/DatadogCore.kt 84.49% <ø> (ø)
...gs/src/main/kotlin/com/datadog/android/log/Logs.kt 84.62% <ø> (ø)
...g/android/rum/internal/DatadogLateCrashReporter.kt 84.71% <ø> (+1.18%) ⬆️
...d/rum/internal/domain/scope/RumApplicationScope.kt 90.41% <ø> (ø)
...droid/rum/internal/domain/scope/RumSessionScope.kt 96.75% <100.00%> (ø)
...d/rum/internal/domain/scope/RumViewManagerScope.kt 96.24% <ø> (ø)
.../android/rum/internal/domain/scope/RumViewScope.kt 93.89% <100.00%> (ø)
.../android/rum/internal/monitor/DatadogRumMonitor.kt 84.62% <100.00%> (ø)
...ernal/vitals/JankStatsActivityLifecycleListener.kt 68.70% <ø> (+0.87%) ⬆️
...d/sessionreplay/material/MaskTabWireframeMapper.kt 100.00% <100.00%> (ø)
... and 4 more

... and 29 files with indirect coverage changes

@0xnm
0xnm merged commit d492ba8 into develop Mar 19, 2024
@0xnm
0xnm deleted the nogorodnikov/adjust-ktlint-formatting-rules branch March 19, 2024 08:39
@0xnm 0xnm mentioned this pull request Mar 19, 2024
Merged
3 tasks
@xgouchet xgouchet added this to the 2.7.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.7.x

Development

Successfully merging this pull request may close these issues.

4 participants

@0xnm @codecov-commenter @xgouchet @mariusc83