RUM-2926: Introduce error.category attribute for exceptions, categorize ANRs separately#1918
Merged
0xnm merged 1 commit intoMar 19, 2024
Conversation
…e ANRs separately
xgouchet
approved these changes
Mar 18, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1918 +/- ##
===========================================
+ Coverage 83.39% 83.40% +0.01%
===========================================
Files 478 478
Lines 17142 17112 -30
Branches 2565 2561 -4
===========================================
- Hits 14295 14272 -23
+ Misses 2140 2133 -7
Partials 707 707
|
Base automatically changed from
nogorodnikov/rum-2879/opt-in-non-fatal-anr-reporting
to
develop
March 18, 2024 10:14
mariusc83
approved these changes
Mar 19, 2024
| attributes.putAll(event.attributes) | ||
|
|
||
| val errorCategory = | ||
| if (event.stackTrace.isNotEmpty()) ErrorEvent.Category.EXCEPTION else null |
Member
There was a problem hiding this comment.
I think the best practice is to add the { } here, is it on one single line though ?
0xnm
deleted the
nogorodnikov/rum-2926/introduce-error-category-for-anrs
branch
March 19, 2024 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR does the following things:
error.categoryattribute, with possible valuesnull|AppHang|ANR|ExceptionANR; if error has throwable attached or non-empty stacktrace -Exception; otherwise it isnull.This property allows better high-level organization of error happening in the application.
Review checklist (to be filled by reviewers)