Skip to content

RUM-2879: Disable non-fatal ANR reporting by default#1914

Merged
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-2879/opt-in-non-fatal-anr-reporting
Mar 18, 2024
Merged

RUM-2879: Disable non-fatal ANR reporting by default#1914
0xnm merged 1 commit into
developfrom
nogorodnikov/rum-2879/opt-in-non-fatal-anr-reporting

Conversation

@0xnm

@0xnm 0xnm commented Mar 14, 2024

Copy link
Copy Markdown
Member

What does this PR do?

This PR disables non-fatal ANR reporting (the one which is using watchdog approach) by default for API 30+, but keeps it enabled on Android API 29 and below (because there is no fatal ANR reporting there).

Customer now has an opportunity to explicitly enable/disable it.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm
0xnm requested review from a team as code owners March 14, 2024 13:51
@0xnm 0xnm mentioned this pull request Mar 14, 2024
Closed
@codecov-commenter

codecov-commenter commented Mar 14, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.39%. Comparing base (5ffa623) to head (5d54877).
⚠️ Report is 2195 commits behind head on develop.

Files with missing lines Patch % Lines
...lin/com/datadog/android/rum/internal/RumFeature.kt 76.92% 0 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1914      +/-   ##
===========================================
- Coverage    83.43%   83.39%   -0.04%     
===========================================
  Files          478      478              
  Lines        17124    17142      +18     
  Branches      2558     2565       +7     
===========================================
+ Hits         14286    14295       +9     
- Misses        2135     2140       +5     
- Partials       703      707       +4
Files with missing lines Coverage Δ
...kotlin/com/datadog/android/rum/RumConfiguration.kt 96.83% <100.00%> (+0.10%) ⬆️
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.38% <76.92%> (-1.16%) ⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Base automatically changed from nogorodnikov/rum-2878/sdk-captures-and-reports-fatal-anrs to develop March 18, 2024 09:34
@0xnm
0xnm merged commit 72d5aeb into develop Mar 18, 2024
@0xnm
0xnm deleted the nogorodnikov/rum-2879/opt-in-non-fatal-anr-reporting branch March 18, 2024 10:14
@xgouchet xgouchet added this to the 2.7.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes
@jonathanmos jonathanmos jonathanmos approved these changes
+1 more reviewer
@xgouchet xgouchet xgouchet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.7.x

Development

Successfully merging this pull request may close these issues.

5 participants

@0xnm @codecov-commenter @xgouchet @mariusc83 @jonathanmos