RUM-3523: Report all threads for non-fatal ANRs#1912
Merged
0xnm merged 1 commit intoMar 15, 2024
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-3523/report-all-threads-for-non-fatal-anrs
branch
from
March 13, 2024 13:22
cb25673 to
1cbed8f
Compare
mariusc83
approved these changes
Mar 13, 2024
mariusc83
left a comment
mariusc83
left a comment
Member
There was a problem hiding this comment.
Just some not blocking comments for me. All seems ok there.
xgouchet
approved these changes
Mar 14, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1912 +/- ##
===========================================
+ Coverage 83.38% 83.39% +0.01%
===========================================
Files 477 477
Lines 16922 16985 +63
Branches 2514 2524 +10
===========================================
+ Hits 14109 14164 +55
- Misses 2120 2126 +6
- Partials 693 695 +2
|
jonathanmos
approved these changes
Mar 14, 2024
0xnm
deleted the
nogorodnikov/rum-3523/report-all-threads-for-non-fatal-anrs
branch
March 15, 2024 09:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds reporting of all threads information for non-fatal ANRs, threads are reported in the same manner as it was done before for crashes (meaning name, state, stacktrace will be reported).
Review checklist (to be filled by reviewers)