RUM-3455 Cleanup SR code #1910
Merged
Merged
Conversation
xgouchet
marked this pull request as draft
March 12, 2024 14:32
0xnm
reviewed
Mar 12, 2024
| * @param drawable the drawable to convert | ||
| * @return the color as an Int (in 0xAARRGGBB order), or null if the drawable is mostly invisible | ||
| */ | ||
| fun mapDrawableToColor(drawable: Drawable): Int? |
Member
There was a problem hiding this comment.
we can put @InternalApi annotation here
mariusc83
reviewed
Mar 13, 2024
xgouchet
force-pushed
the
xgouchet/RUM-3455/fix_sr_bugs
branch
5 times, most recently
from
March 14, 2024 09:59
82a2bec to
b109884
Compare
xgouchet
marked this pull request as ready for review
March 14, 2024 10:30
0xnm
approved these changes
Mar 14, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
nice! I added few comments, but they are not blocking.
xgouchet
force-pushed
the
xgouchet/RUM-3455/fix_sr_bugs
branch
from
March 14, 2024 13:02
b109884 to
a5ca09d
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1910 +/- ##
=========================================
Coverage 83.38% 83.38%
=========================================
Files 477 480 +3
Lines 16922 17159 +237
Branches 2514 2534 +20
=========================================
+ Hits 14109 14307 +198
- Misses 2120 2154 +34
- Partials 693 698 +5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR performs some cleanup in our Session Replay code
Motivation
Originally, it was to better handle the mask layer in Ripple Drawables + the color of gradients when using tint (which resolves to a color filter).
And then I just tried to make the code cleaner and it impacted more in the end 😅