RUM-2878: Report fatal ANRs#1909
Merged
0xnm merged 1 commit intoMar 18, 2024
Merged
Conversation
0xnm
force-pushed
the
nogorodnikov/rum-2878/sdk-captures-and-reports-fatal-anrs
branch
from
March 12, 2024 12:57
a295175 to
b6f9e6c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1909 +/- ##
===========================================
+ Coverage 83.38% 83.43% +0.05%
===========================================
Files 477 478 +1
Lines 16922 17124 +202
Branches 2514 2558 +44
===========================================
+ Hits 14109 14286 +177
- Misses 2120 2135 +15
- Partials 693 703 +10
|
jonathanmos
approved these changes
Mar 14, 2024
0xnm
force-pushed
the
nogorodnikov/rum-2878/sdk-captures-and-reports-fatal-anrs
branch
from
March 14, 2024 10:21
b6f9e6c to
c8b1fce
Compare
0xnm
force-pushed
the
nogorodnikov/rum-2878/sdk-captures-and-reports-fatal-anrs
branch
from
March 14, 2024 13:47
c8b1fce to
5ffa623
Compare
0xnm
deleted the
nogorodnikov/rum-2878/sdk-captures-and-reports-fatal-anrs
branch
March 18, 2024 09:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support of reporting fatal ANRs (ANR which resulted in the
Application Not Respondingdialog where user decided to close the application).This functionality relies on the ApplicationExitInfo API (available since Android API 30), which can be read on the next application run. So in that sense it is similar to the approach we have to report NDK crashes: on the next application run we need to run this information and match it with the last RUM view event we know.
Since we cannot mark a particular
ApplicationExitInfoas read in the system, we have to store the timestamp of the lastApplicationExitInfowe processed to avoid the possible delivery on the next application run.When processing
ApplicationExitInfo, we will read trace information attached to it and try to parse it (it is non-structured log).This PR doesn't add the possibility to disable reporting of non-fatal (or unknown) ANRs, and it doesn't add
error.categoryinfo, this will be done in next PRs.Review checklist (to be filled by reviewers)