Fix typo in source type#1904
Merged
Merged
Conversation
fuzzybinary
marked this pull request as ready for review
March 5, 2024 15:40
0xnm
approved these changes
Mar 5, 2024
mariusc83
approved these changes
Mar 5, 2024
xgouchet
approved these changes
Mar 5, 2024
jonathanmos
approved these changes
Mar 5, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1904 +/- ##
===========================================
- Coverage 83.44% 83.21% -0.23%
===========================================
Files 477 477
Lines 16911 16877 -34
Branches 2512 2507 -5
===========================================
- Hits 14110 14043 -67
- Misses 2113 2134 +21
- Partials 688 700 +12
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The log attribute for source type had a . instead of an _ which breaks the cross platform contract.
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)