RUM-3276: Fix image resizing issue#1897
Merged
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1897 +/- ##
===========================================
+ Coverage 83.31% 83.43% +0.12%
===========================================
Files 477 477
Lines 16864 16926 +62
Branches 2504 2514 +10
===========================================
+ Hits 14050 14122 +72
+ Misses 2122 2120 -2
+ Partials 692 684 -8
|
jonathanmos
marked this pull request as ready for review
March 4, 2024 09:29
0xnm
approved these changes
Mar 4, 2024
xgouchet
approved these changes
Mar 4, 2024
mariusc83
approved these changes
Mar 5, 2024
mariusc83
left a comment
mariusc83
left a comment
Member
There was a problem hiding this comment.
Nice job !! Can you please also mark the issue as closed once you merge this ?
jonathanmos
force-pushed
the
jmoskovich/rum-3276/fix-resized-drawables
branch
from
March 5, 2024 13:13
26de2cb to
b8802bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a resizing issue due to setbounds on the drawable. We need to perform this operation on a copy of the drawable to avoid modifying the viewtree.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)