feat: Add source_type when sent from cross platform logs#1895
Merged
Conversation
Send `source_type` as a property on `error` when the attribute `_dd.error.source_type` is set on the log.
fuzzybinary
force-pushed
the
jward/source_type
branch
from
February 29, 2024 14:49
36c5012 to
5cb4f3e
Compare
xgouchet
approved these changes
Mar 1, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1895 +/- ##
===========================================
- Coverage 83.33% 83.32% -0.01%
===========================================
Files 479 479
Lines 16952 16955 +3
Branches 2527 2528 +1
===========================================
+ Hits 14126 14127 +1
- Misses 2133 2136 +3
+ Partials 693 692 -1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This will send
source_typeas a property onerrorwhen the attribute_dd.error.source_typeis set on the log.Motivation
The
source_typeproperty is not being populated on logs. This isn't too big of an issue as symbolication will default back tosource, but there are cases where we'll need thesource_typeto do proper symbolication.Review checklist (to be filled by reviewers)