(1/10) RUM-2895 create SR Compose module#1879
Merged
Merged
Conversation
0xnm
previously approved these changes
Feb 23, 2024
| javadocConfig() | ||
| dependencyUpdateConfig() | ||
| publishingConfig( | ||
| "Session Replay Extension Support for Material UI components." |
Member
There was a problem hiding this comment.
Suggested change
| "Session Replay Extension Support for Material UI components." | |
| "Session Replay Extension Support for Jetpack Compose." |
Comment on lines
+1
to
+3
|
|
||
|
|
||
| ## ComposeView & AndroidComposeView |
Member
There was a problem hiding this comment.
Suggested change
| ## ComposeView & AndroidComposeView | |
| ## ComposeView & AndroidComposeView |
hestonhoffman
previously approved these changes
Feb 23, 2024
hestonhoffman
left a comment
hestonhoffman
left a comment
Contributor
There was a problem hiding this comment.
LGTM once other comments are addressed.
mariusc83
previously approved these changes
Feb 26, 2024
xgouchet
dismissed stale reviews from mariusc83, hestonhoffman, and 0xnm
February 26, 2024 10:04
The base branch was changed.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #1879 +/- ##
======================================================
- Coverage 83.40% 83.31% -0.10%
======================================================
Files 479 479
Lines 16935 16934 -1
Branches 2527 2527
======================================================
- Hits 14124 14107 -17
- Misses 2128 2135 +7
- Partials 683 692 +9 |
jonathanmos
approved these changes
Mar 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR has been created automatically by splitting a large branch
RUM-2895 create SR Compose module