RUM-2708: Refactor and split classes#1873
Merged
Merged
Conversation
jonathanmos
force-pushed
the
jmoskovich/rum-2708/new-refactor
branch
from
February 25, 2024 12:53
e65bd40 to
1e951e9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1873 +/- ##
===========================================
- Coverage 83.34% 83.31% -0.03%
===========================================
Files 481 483 +2
Lines 17408 17390 -18
Branches 2589 2593 +4
===========================================
- Hits 14508 14487 -21
Misses 2193 2193
- Partials 707 710 +3
|
jonathanmos
marked this pull request as ready for review
February 28, 2024 08:39
Base automatically changed from
jmoskovich/rum-2708/enable-resource-endpoint
to
develop
March 5, 2024 11:26
jonathanmos
changed the title
jonathanmos
force-pushed
the
jmoskovich/rum-2708/new-refactor
branch
from
March 6, 2024 09:37
d7311ed to
ce43622
Compare
0xnm
reviewed
Mar 6, 2024
0xnm
approved these changes
Mar 12, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-2708/new-refactor
branch
from
March 14, 2024 08:32
737969c to
6ccbc24
Compare
0xnm
approved these changes
Mar 14, 2024
jonathanmos
force-pushed
the
jmoskovich/rum-2708/new-refactor
branch
from
March 21, 2024 08:32
6ccbc24 to
a6623d2
Compare
0xnm
approved these changes
Mar 21, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
lgtm! I added few questions, but I don't think they are blocking for me.
jonathanmos
force-pushed
the
jmoskovich/rum-2708/new-refactor
branch
from
March 21, 2024 11:01
a6623d2 to
ffe71a7
Compare
0xnm
approved these changes
Mar 21, 2024
xgouchet
approved these changes
Mar 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous pr had unresolvable git conflicts so I've recreated the commits on a new branch.
What does this PR do?
• Extract cache logic into BitmapCacheManager
• Rename ResourcesSerializer to ResourceResolver
• Move ResourceDataQueueItem insertion into the DataQueueHandler to a new ResourceItemCreationHandler
• Cleanup the callbacks so that all exit points from the ResourceResolver come from the same method
• Add telemetry/maintainer logging to failures in MD5 hash generation and webp compression
• Remove mimetype from the wireframe (no longer needed because resource endpoint requests already contain the content type)
Motivation
Separate the refactor pr from the pr that removes the feature flag, to make it easier to review
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)