RUM-3311 prevent crash when window is not hardware accelerated#1872
Merged
Conversation
xgouchet
force-pushed
the
xgouchet/RUM-3311/crash
branch
from
February 22, 2024 15:14
d3b6616 to
39bba95
Compare
0xnm
previously approved these changes
Feb 22, 2024
0xnm
left a comment
0xnm
left a comment
Member
There was a problem hiding this comment.
nice, lgtm! I've added a few thoughts, but they are not blocking.
jonathanmos
previously approved these changes
Feb 22, 2024
xgouchet
force-pushed
the
xgouchet/RUM-3311/crash
branch
from
February 23, 2024 08:15
39bba95 to
4f1fb48
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/2.6.0 #1872 +/- ##
=================================================
- Coverage 83.64% 83.50% -0.15%
=================================================
Files 470 470
Lines 16629 16632 +3
Branches 2499 2499
=================================================
- Hits 13909 13887 -22
- Misses 2050 2062 +12
- Partials 670 683 +13
|
0xnm
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevent a crash when adding the JankStats listener
Fixes #1875