RUM-3150 Set source_type on native crashes to ndk#1856
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1856 +/- ##
===========================================
- Coverage 83.48% 83.41% -0.07%
===========================================
Files 470 470
Lines 16601 16601
Branches 2495 2495
===========================================
- Hits 13858 13847 -11
- Misses 2062 2072 +10
- Partials 681 682 +1
|
0xnm
approved these changes
Feb 16, 2024
fuzzybinary
force-pushed
the
jward/RUM-3150-native-source-type-override
branch
from
February 16, 2024 14:22
14bf556 to
aa418ec
Compare
fuzzybinary
force-pushed
the
jward/RUM-3150-native-source-type-override
branch
from
February 16, 2024 14:53
aa418ec to
9a7bc10
Compare
0xnm
approved these changes
Feb 16, 2024
Also provide a way to override the native crash type by setting `_dd.native_source_type` in the additional configuration.
fuzzybinary
force-pushed
the
jward/RUM-3150-native-source-type-override
branch
from
February 16, 2024 15:54
9a7bc10 to
a34d834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
To properly symbolicate NDK crashes, we need to know that the provided stack trace is an NDK trace, instead of a standard Java stack trace. This changes it so that crashes caught by the NDK crash reporter report an
error.source_typeas "ndk" to both Logs and RUM.Additionally, because certain platforms will want to override symbolication behavior, we provide a way to change the default native source type by using the
_dd.native_source_typeadditional configuration option.Review checklist (to be filled by reviewers)